-
Notifications
You must be signed in to change notification settings - Fork 324
CQL combo 2.0.0 Upgrade - Full PD$apply implementation #1603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h androidTest and test
…ithout a type property)
…dcoded assertions
Contributor
|
@Tarun-Bhardwaj can you give an update on this? since this is approved, and the failures seem to be network related, is it possible to go ahead and merge? |
Contributor
Author
|
We also need more memory for the GitHub Actions machines. Either that or we need to stop running things in parallel with shared gradle deamon. |
# Conflicts: # kokoro/gcp_ubuntu/kokoro_build.sh # workflow/build.gradle.kts
Contributor
Author
|
@jingtang10 now without the changes in the test environment (P->O), as requested. |
jingtang10
approved these changes
Oct 7, 2022
...rc/test/java/com/google/android/fhir/datacapture/contrib/views/barcode/mlkit/md/UtilsTest.kt
Show resolved
Hide resolved
jingtang10
approved these changes
Oct 7, 2022
# Conflicts: # catalog/build.gradle.kts # contrib/barcode/build.gradle.kts # datacapture/build.gradle.kts
This was referenced Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1403, #1423, #1407, #1365, #915, #656, #718
Unlocks: #1334, #1055, #1189
Depreciates: #1395
Description
This PR brings the full functionality of the $apply operator to Android.
androidTestandtest.FhirEngineRetrieveProvidernow uses the existingXFhirQueryTranslatorto automatically create filtering parameters based on previously-annotated context paths;FhirEngineRetrieveProviderand provides testing coverage for all types of filters:FhirEngineTerminologyProviderwith a lookup function and reviews all other functions to behave in a similar way to a desktop version. Test cases were added to cover all desktop use casesactive=trueclause forFhirEngineRetrieveProvidersearches involving Patients was deleted in favor ofactive=trueclauses in the CQL files. CQL authors are supposed to filter active records in the CQL itself, not in the provider.Thanks to:
Alternative(s) considered
No
Type
Choose one: Feature
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.