Remove move ctor/assignment from TriStatePtr::SharedRef#144
Merged
copybara-service[bot] merged 1 commit intomainfrom Jan 9, 2025
Merged
Remove move ctor/assignment from TriStatePtr::SharedRef#144copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_713667208
branch
2 times, most recently
from
e998d43 to
e0a43b9
Compare
Moving TriStatePtr::SharedRef is error prone to get the refcount right. While it is possible to implement one, the use case is so rare to justify. PiperOrigin-RevId: 713670111
copybara-service
bot
force-pushed
the
test_713667208
branch
from
e0a43b9 to
64637c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove move ctor/assignment from TriStatePtr::SharedRef
Moving TriStatePtr::SharedRef is error prone to get the refcount right.
While it is possible to implement one, the use case is so rare to justify.