Skip to content

Apply std::move() to final occurrences of options. #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jun 5, 2025
Merged

Apply std::move() to final occurrences of options. #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion python/array_record_module.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ limitations under the License.

#include <stdexcept>
#include <string>
#include <utility>
#include <vector>

#include "absl/status/status.h"
Expand Down Expand Up @@ -91,7 +92,8 @@ PYBIND11_MODULE(array_record_module, m) {
// Release the GIL because IO is time consuming.
py::gil_scoped_release scoped_release;
return new array_record::ArrayRecordReader(
riegeli::Maker<riegeli::FdReader>(path, file_reader_options),
riegeli::Maker<riegeli::FdReader>(
path, std::move(file_reader_options)),
status_or_option.value(),
array_record::ArrayRecordGlobalPool());
}),
Expand Down
Loading