Skip to content

Remove per-chunk flushing to speedup AR write speed. #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jun 18, 2025
Merged

Remove per-chunk flushing to speedup AR write speed. #160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions cpp/sequenced_chunk_writer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,12 +126,6 @@ void SequencedChunkWriterBase::TrySubmitFirstFutureChunk(
return;
}
}
if (!chunk_writer->Flush(riegeli::FlushType::kFromObject)) {
Fail(riegeli::Annotate(
chunk_writer->status(),
absl::StrFormat("Could not flush chunk: %d", submitted_chunks_)));
return;
}
if (callback_) {
(*callback_)(submitted_chunks_, chunk_offset, decoded_data_size,
num_records);
Expand All @@ -148,9 +142,6 @@ void SequencedChunkWriterBase::Initialize() {
Fail(riegeli::Annotate(chunk_writer->status(),
"Failed to create the file header"));
}
if (!chunk_writer->Flush(riegeli::FlushType::kFromObject)) {
Fail(riegeli::Annotate(chunk_writer->status(), "Could not flush"));
}
}

void SequencedChunkWriterBase::Done() {
Expand Down
Loading