Skip to content

Add Windows build#161

Draft
mtsokol wants to merge 1 commit intogoogle:mainfrom
mtsokol:windows-build
Draft

Add Windows build#161
mtsokol wants to merge 1 commit intogoogle:mainfrom
mtsokol:windows-build

Conversation

@mtsokol
Copy link
Contributor

@mtsokol mtsokol commented Jun 25, 2025

Hi @iindyk,

Here's a workflow to build array_record with a Windows artifact.

@mtsokol
Copy link
Contributor Author

mtsokol commented Jun 25, 2025

Ok, it's not only the build-and-publish.yml file, I need to port also a few others from your fork.

@mtsokol

This comment was marked as outdated.

@mtsokol
Copy link
Contributor Author

mtsokol commented Jun 25, 2025

Ahh, I forgot about extra BAZEL_VERSION in the yaml. Specifying same version in two different places was the culprit. Looks like it ends up with compilation errors, depending on a Bazel version.

@mtsokol
Copy link
Contributor Author

mtsokol commented Jun 25, 2025

Ok, so right now the configuration looks fine, the build starts but each windows job fails with different compilation errors: https://github.com/mtsokol/array_record/actions/runs/15879944885/job/44777320871

It uses latest windows image and visual studio, and tried a few Bazel versions for it. I think there needs to be separate effort to make array_record build for Windows and a new release first.

@mtsokol
Copy link
Contributor Author

mtsokol commented Jul 8, 2025

This needs to be revisited once #162 is merged.

@mtsokol mtsokol marked this pull request as draft July 8, 2025 14:58
@mtsokol mtsokol force-pushed the windows-build branch 3 times, most recently from ee533f8 to 96be945 Compare July 15, 2025 09:12
@mtsokol
Copy link
Contributor Author

mtsokol commented Jul 15, 2025

After updating protobuf the build still fails with some compilation errors, so there should be a separate effort to make array_record work on Windows platform: https://github.com/mtsokol/array_record/actions/runs/16289745929

@iindyk
Copy link
Collaborator

iindyk commented Jul 18, 2025

thanks for trying this out! we'll try the optional dep in Grain as discussed and put this on the back burner for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants