Skip to content

Fix workflow permissions and requirements build. #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jul 15, 2025
Merged

Fix workflow permissions and requirements build. #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/python-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,8 @@ on:
jobs:
call-workflow:
uses: ./.github/workflows/build_and_publish_template.yml
permissions:
contents: read
id-token: write
Comment on lines +10 to +12
Copy link
Contributor

@mtsokol mtsokol Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it should be here.

with:
upload_wheels: false
0 oss/.gitignore → .gitignore
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion python/array_record_data_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def __getitem__(self, record_keys: Sequence[int]) -> Sequence[T]:
from absl import logging
from etils import epath

from python import array_record_module
from . import array_record_module

# TODO(jolesiak): Decide what to do with these flags, e.g., remove them (could
# be appropriate if we decide to use asyncio) or move them somewhere else and
Expand Down
16 changes: 0 additions & 16 deletions python/array_record_data_source_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,22 +247,6 @@ def test_repr(self):
])
self.assertRegex(repr(ar), r"ArrayRecordDataSource\(hash_of_paths=[\w]+\)")

@flagsaver.flagsaver(grain_use_fast_array_record_reader=False)
def test_additional_reader_options(self):
indices_to_read = [3, 0, 5, 9, 2, 1, 4, 7, 8, 6]
ar = array_record_data_source.ArrayRecordDataSource(
[
self.testdata_dir / "digits.array_record-00000-of-00002",
self.testdata_dir / "digits.array_record-00001-of-00002",
],
{"index_storage_option": "in_memory"},
)
# We need to read the records to trigger the creation of the readers.
_ = [ar[x] for x in indices_to_read]
self.assertLen(ar._readers, 2)
self.assertIsInstance(ar._readers[0], array_record_module.ArrayRecordReader)
self.assertIsInstance(ar._readers[1], array_record_module.ArrayRecordReader)


class RunInParallelTest(parameterized.TestCase):

Expand Down
0 oss/test_requirements.in → test_requirements.in
View file
Open in desktop
File renamed without changes.
0 oss/test_requirements_lock_3_10.txt → test_requirements_lock_3_10.txt
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion oss/test_requirements_lock_3_11.txt → test_requirements_lock_3_11.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ typing-extensions==4.14.1 \
zipp==3.23.0 \
--hash=sha256:071652d6115ed432f5ce1d34c336c0adfd6a884660d1e9712a256d3d3bd4b14e \
--hash=sha256:a07157588a12518c9d4034df3fbbee09c814741a33ff63c05fa29d26a2404166
# via etils
# via etils
2 changes: 1 addition & 1 deletion oss/test_requirements_lock_3_12.txt → test_requirements_lock_3_12.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ typing-extensions==4.14.1 \
zipp==3.23.0 \
--hash=sha256:071652d6115ed432f5ce1d34c336c0adfd6a884660d1e9712a256d3d3bd4b14e \
--hash=sha256:a07157588a12518c9d4034df3fbbee09c814741a33ff63c05fa29d26a2404166
# via etils
# via etils
2 changes: 1 addition & 1 deletion oss/test_requirements_lock_3_13.txt → test_requirements_lock_3_13.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ typing-extensions==4.14.1 \
zipp==3.23.0 \
--hash=sha256:071652d6115ed432f5ce1d34c336c0adfd6a884660d1e9712a256d3d3bd4b14e \
--hash=sha256:a07157588a12518c9d4034df3fbbee09c814741a33ff63c05fa29d26a2404166
# via etils
# via etils