A bunch of fix #25
Open
A bunch of fix #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang use DW_FORM_ref_addr for DW_AT_abstract_origin when doing LTO. When searching for abstract_origin subprograms, we need to search all CUs. CleanupUnusedSubprograms is disabled because there may be links to it afterwards.(ps: maybe cleanup is needed after parsing of all CUs are done?)
llvm profile output. For top level symbols, their start_line in SymbolMap are alwarys 0, since in SymbolMap::AddSourceCount top level symbol do not take the value from SourceStack. For Inlined symbols, their start_line in SymbolMap are assigned in SymbolMap::TraverseInlineStack. Fix by assign correct start_line to top level symbols and change LLVMSourceProfileWriter::WriteSourceLocation accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google CLA signed.