Fix stack overflow from recursive DWO references #479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent infinite recursion in ReadDWARFDebugInfo when a DWO file contains a DW_AT_GNU_dwo_name attribute pointing to itself. We now only follow DWO links if the current CU is a skeleton CU. Issue google#344 Fixes google#476
Adds a test case simulating a self-referential DWO file to ensure recursion is handled gracefully without crashing. See google#476
Collaborator
Author
|
@haberman Mind taking a look at this small one line fix for handling an issue with chrome's split dwarf builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent infinite recursion in ReadDWARFDebugInfo when a DWO file
contains a
DW_AT_GNU_dwo_nameattribute pointing to itself.We now only follow DWO links if the current CU is a skeleton CU.
Issue #344
Fixes #476