add basic support for SCI #871
Open
+883
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxzxwu
approved these changes
Jan 23, 2026
| frame_space_min: int = field(metadata=metadata(2)) | ||
| frame_space_max: int = field(metadata=metadata(2)) | ||
| phys: int = field(metadata=PhyBit.type_metadata(1)) | ||
| spacing_types: int = field(metadata=SpacingType.type_metadata(1)) |
Collaborator
There was a problem hiding this comment.
Should be SpacingType.type_metadata(2)?
| ) | ||
|
|
||
| if self.cis_enabled: | ||
| if self.cis_enabled and self.host.supports_command( |
Collaborator
There was a problem hiding this comment.
I am thinking if we should have some warning if some configs cannot be fulfilled due to the lack of support in controller, but it will make the flow control a bit too long-winded here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows setting shorter connection intervals with controllers that support the feature (introduced in spec version 6.2)