Skip to content

Conversation

@sritchie
Copy link
Contributor

Dependencies are much more expensive to change than credentials. This PR moves the credential injection after dependency fetching.

This is a decent idea, I think, BUT it has a problem. If you have private dependencies in a google Source Cloud Repository, you need the credentials to come before the pip install so that git can use gcloud for authentication.

@ajslone , I'm going to vote that we:

  • make this change here, but only after
  • we add a setting in .calibanconfig.json that allows you to move this earlier if you need it there.

I am a little worried at configuration options starting to increase. What do you think?

Change-Id: Ic514cf705942e98eadb63caca626a2df5e5fd2fb
@sritchie sritchie requested a review from ajslone June 16, 2020 22:08
@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 43.64%. Comparing base (4fbfe5f) to head (dfe6948).
Report is 89 commits behind head on main.

Files with missing lines Patch % Lines
caliban/docker.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   43.73%   43.64%   -0.10%     
==========================================
  Files          20       20              
  Lines        3114     3114              
==========================================
- Hits         1362     1359       -3     
- Misses       1752     1755       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@ajslone ajslone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like the right thing to do, but I hear your concerns over over-configurability and its impact on usability. I'd say that as long as there are rational defaults, and there is some way to keep a persistent configuration then this should be ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants