Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@khmyznikov FYI |
MaciejEteruniversum
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds CI and MSVC ARM64 support for the crc32c library.
MSVC ARM64 builds were missing intrinsic handling and had placeholder flags (
/arch:NOTYET). This PR replaces those placeholders with proper MSVC ARM64 implementation and adds awindows-11-armCI runner to validate it.Changes:
windows-11-armto the OS matrix with MSVC-only builds, pass-A ARM64to CMake for ARM64 target generation/arch:NOTYETplaceholder with proper MSVC ARM64 intrinsic detection; skip/arch:armv8.0flag when natively targeting ARM64Arm64_Vmull_P64wrapper usingneon_pmull_64, replacepoly64_twithuint64_tfor MSVC compatibilityIsProcessorFeaturePresent