Add CRUBIT_THREAD_SAFE annotation and use it for Send + Sync#745
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Add CRUBIT_THREAD_SAFE annotation and use it for Send + Sync#745copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Add a new CRUBIT_THREAD_SAFE annotation that marks C++ types as thread-safe for Rust interop. This CL: - Adds the annotation macro in annotations.h - Parses the annotation in the CXX record importer, setting the TraitDerives send and sync flags to true so the struct natively gets `unsafe impl Send` and `unsafe impl Sync` - Adds the is_thread_safe field to the IR Record struct for future use PiperOrigin-RevId: 886895198
copybara-service
bot
force-pushed
the
test_886895198
branch
from
bb3b2ef to
374462a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CRUBIT_THREAD_SAFE annotation and use it for Send + Sync
Add a new CRUBIT_THREAD_SAFE annotation that marks C++ types as thread-safe
for Rust interop. This CL:
send and sync flags to true so the struct natively gets
unsafe impl Sendand
unsafe impl Sync