Wrap CRUBIT_THREAD_SAFE types in UnsafeCell#746
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Wrap CRUBIT_THREAD_SAFE types in UnsafeCell#746copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
For types annotated with CRUBIT_THREAD_SAFE, replace the normal Rust struct fields with a single opaque UnsafeCell<[MaybeUninit<u8>; SIZE]> body. This enables interior mutability, allowing non-const C++ methods to be called through shared references. This also prevents standard Rust `#[derive(Copy, Clone)]` generation, and forces an explicit alignment override since the opaque byte array body has alignment 1. PiperOrigin-RevId: 886895197
copybara-service
bot
force-pushed
the
test_886895197
branch
from
c53bb8e to
83c106e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap CRUBIT_THREAD_SAFE types in UnsafeCell
For types annotated with CRUBIT_THREAD_SAFE, replace the normal Rust struct
fields with a single opaque UnsafeCell<[MaybeUninit; SIZE]> body.
This enables interior mutability, allowing non-const C++ methods to be
called through shared references.
This also prevents standard Rust
#[derive(Copy, Clone)]generation,and forces an explicit alignment override since the opaque byte array body
has alignment 1.