Add a bit to pointer types to decide if they should be CRef/CMut.#774
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 28, 2026
Merged
Add a bit to pointer types to decide if they should be CRef/CMut.#774copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_890517999
branch
from
a7960e9 to
a2fda30
Compare
This is not a new PointerTypeKind because it's a Rust-side representation decision. Right now we're aiming to lower LValueRef in output positions to CRef/CMut, but in the future we may also want to lower NonNull. (These require us to generate slightly different code on the C++ side.) Making this a property of the pointer type reduces the state we need to carry around later on, as the decision to use CRef vs const& again depends on the semantic location of the reference. (It's kind of clear when you think about returns vs parameters, but this becomes more complicated when we consider function types.) PiperOrigin-RevId: 890766422
copybara-service
bot
force-pushed
the
test_890517999
branch
from
a2fda30 to
921d31b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a bit to pointer types to decide if they should be CRef/CMut.
This is not a new PointerTypeKind because it's a Rust-side
representation decision. Right now we're aiming to lower
LValueRef in output positions to CRef/CMut, but in the future we
may also want to lower NonNull. (These require us to generate
slightly different code on the C++ side.)
Making this a property of the pointer type reduces the state we
need to carry around later on, as the decision to use CRef vs const&
again depends on the semantic location of the reference.
(It's kind of clear when you think about returns vs parameters, but
this becomes more complicated when we consider function types.)