Fix bugs in new all_public_paths_by_def_id logic.#775
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 27, 2026
Merged
Fix bugs in new all_public_paths_by_def_id logic.#775copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_890533066
branch
2 times, most recently
from
275142b to
a0bb237
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_890533066
branch
from
a0bb237 to
5162ecb
Compare
PublicPaths::merge was using `<` when it should've been `>` leading to a preference for dependencies instead of the source crate when both were available. I've fixed the bug and added a test for it. `symbol_unqualified_name` wasn't using `all_public_paths_by_def_id` causing symbols to be spelled with a valid path but an invalid name. Updated the logic to use `all_public_paths` to account for renaming in the unqualified symbol name. PiperOrigin-RevId: 890604192
copybara-service
bot
force-pushed
the
test_890533066
branch
from
5162ecb to
8cff812
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bugs in new all_public_paths_by_def_id logic.
PublicPaths::merge was using
<when it should've been>leading to a preferencefor dependencies instead of the source crate when both were available.
I've fixed the bug and added a test for it.
symbol_unqualified_namewasn't usingall_public_paths_by_def_idcausing symbols to be spelled with a valid path but an invalid name. Updated the logic to useall_public_pathsto account for renaming in the unqualified symbol name.