Update the package json with scripts! #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ayer-helper into updatePackageJSON
…into updatePackageJSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our package json has a lot of missing stuff which would make the library look more professional, see #5. That commit can't ever get merged since the contributor did not sign the CLA, though. So that's one reason for this commit. The other reason is that, by using the scripts property of the package json, we can simplify the build instructions in the README by a lot. (Bonus: It doesn't affect the current workflow if you want to ignore it). Scripts run by npm or yarn automatically add your project's node_modules/.bin/ folder to the $PATH before it runs the command, so there is no need for a global install. I think that is pretty cool and good.
Also I updated the version from 0.1.0 to 1.0.0 since we have been adding features and making a major update.