Building Onboarding PR #1560
Merged
Building Onboarding PR #1560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shambergoldstein
requested changes
May 21, 2025
Merging master into current branch to sync updates
|
@shambergoldstein Few comments back for you, but should be ready for review! |
shambergoldstein
requested changes
May 22, 2025
|
@ccquigley Ready for your review! Just wrapped up the other comments. |
ccquigley
approved these changes
May 23, 2025
shambergoldstein
approved these changes
May 27, 2025
shambergoldstein
requested changes
May 27, 2025
|
@hhunterr71 the validation is still failing, please remove the duplicate fields on ECOND |
|
@shambergoldstein Fixed |
shambergoldstein
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR affects the following types:
ABSTRACT, AHU, CDWS, CH, CHWS, CT, DHWT, FAN, FCU, HWS, MAU, SENSOR,UH.