Conversation
| @@ -0,0 +1,14 @@ | |||
| { | |||
There was a problem hiding this comment.
I do not see that these files are part of source code. instead these files looks like tests configuration and it will be better to keep these files closer to the place they will be used (tests).
There was a problem hiding this comment.
Our initial idea was that introducing the files list configuration in the dumper source code would make life easier for the PR owner, for example when the PR replaces a file name with a new one, the light tests will fail, as the file from the file list is not found inside the dump. Then the developer could update the file list with the new file name and the tests would succeed. If we place the file lists in the tests repository, one would have to make another CL to update the files list and this could be annoying.
These are of course only our thoughts, and if you don't think the files belong in the dumper repository, we will move them, just let us know.
There was a problem hiding this comment.
The idea is nice.
My concern is these files still not part of the source code and if I as developer will do a typo or I will just forget to update the list everything will work for me. It's why I think this config should not be here.
I see at least 2 better options:
- Move files to internal google repo (where the integration tests are located)
- create some configuration folder in the root of the repo GitHub and move these files to this folder. (examples
.github/,.security/)
Manual merge of krykania#10