Skip to content

No public description #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

No public description #1952

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion centipede/testing/build_defs.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ def _sancov_transition_impl(settings, attr):
for x in settings["//command_line_option:features"]
if x not in features_to_strip
]
compiler = settings["//command_line_option:compiler"]
compilers_to_disable = ["tsan", "msan"]
if compiler in compilers_to_disable:
compiler = None

# some of the valid sancov flag combinations:
# trace-pc-guard,pc-table
Expand All @@ -51,7 +55,7 @@ def _sancov_transition_impl(settings, attr):
"//command_line_option:compilation_mode": "opt",
"//command_line_option:strip": "never", # preserve debug info.
"//command_line_option:features": filtered_features,
"//command_line_option:compiler": None,
"//command_line_option:compiler": compiler,
"//command_line_option:dynamic_mode": "off",
}

Expand All @@ -60,6 +64,7 @@ sancov_transition = transition(
inputs = [
"//command_line_option:copt",
"//command_line_option:features",
"//command_line_option:compiler",
],
outputs = [
"//command_line_option:collect_code_coverage",
Expand Down
Loading