Skip to content

Conversation

zyfy29
Copy link
Contributor

@zyfy29 zyfy29 commented Sep 27, 2025

close #3699

follows https://go.dev/blog/go1.13-errors to handle error types with errors package

@zyfy29
Copy link
Contributor Author

zyfy29 commented Sep 27, 2025

Actually I added a lint rule go-errorlint to do it, would you like to add it to this project? If so I could open another pr to do it because I think it's better to leave 2 commit for refactor: and ci:.

@gmlewis
Copy link
Collaborator

gmlewis commented Sep 27, 2025

Actually I added a lint rule go-errorlint to do it, would you like to add it to this project? If so I could open another pr to do it because I think it's better to leave 2 commit for refactor: and ci:.

That sounds great, thank you, @zyfy29!

@gmlewis
Copy link
Collaborator

gmlewis commented Sep 27, 2025

Also, please fix the broken tests and linter errors.

@zyfy29 zyfy29 requested a review from gmlewis September 28, 2025 02:18
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

❌ Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.11%. Comparing base (138500e) to head (cfb2efb).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
example/basicauth/main.go 0.00% 1 Missing ⚠️
github/github.go 95.65% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3739   +/-   ##
=======================================
  Coverage   91.11%   91.11%           
=======================================
  Files         187      187           
  Lines       16697    16702    +5     
=======================================
+ Hits        15213    15218    +5     
  Misses       1296     1296           
  Partials      188      188           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zyfy29 zyfy29 requested a review from gmlewis September 29, 2025 05:55
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @zyfy29! I like this much better.
Just a few more questions and suggestions for you, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging since many things have changed from the first review.

Copy link
Contributor Author

@zyfy29 zyfy29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the mistakes, I found most of them are made by Intellij IDEA's quick-fix and now I've checked it again.

@zyfy29 zyfy29 requested a review from gmlewis September 30, 2025 06:16
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @zyfy29!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging (since many changes have occurred since first approval).

cc: @stevehipwell - @alexandear

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Sep 30, 2025
Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Sep 30, 2025
@gmlewis
Copy link
Collaborator

gmlewis commented Sep 30, 2025

Thank you, @stevehipwell!
Merging.

@zyfy29 - please follow up with a PR that enables linting for the usage of the errors package. Thank you!

@gmlewis gmlewis merged commit cd80b0a into google:master Sep 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Use errors.As instead of type assertions internally
4 participants