Open
Conversation
jrepp
added a commit
to jrepp/goblet
that referenced
this pull request
Nov 7, 2025
Merges google/goblet PR #10 by @mdehoog google#10 Respects the token type (Bearer vs Basic) for authentication. GitHub Enterprise expects personal access tokens using basic auth instead of bearer. This change uses the token type from the token itself rather than hardcoding 'Bearer'. Changes: - Changed hardcoded 'Bearer' to use t.Type() in git fetch commands - Combined with empty token check from previous merge - Already working for lsRefsUpstream via SetAuthHeader - No impact on existing users (Bearer is the default) Conflicts resolved: - managed_repository.go: Combined t.Type() usage with empty token checks
This was referenced Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at using this to cache some Github Enterprise repos, and Github expects personal access tokens to be passed using basic auth instead of bearer. This PR respects the type passed in the token (will not affect existing users, as
Beareris the default).Note that this already works for the
lsRefsUpstreammethod because the token is applied usingSetAuthHeader:goblet/managed_repository.go
Line 142 in d246de9