Skip to content

Cancel buffer join thread on worker shutdown. #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cancel buffer join thread on worker shutdown. #1201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion grain/_src/python/dataset/transformations/process_prefetch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def _clear_queue_and_maybe_unlink_shm(q: queues.Queue[Any]) -> int:
try:
shared_memory_array.unlink_shm(q.get_nowait())
count += 1
except queue.Empty:
except Exception: # pylint: disable=broad-except
return count


Expand Down Expand Up @@ -261,7 +261,11 @@ def _put_dataset_elements_in_buffer(
)
return
_clear_queue_and_maybe_unlink_shm(buffer)
buffer.cancel_join_thread()
buffer.close()
_clear_queue_and_maybe_unlink_shm(set_state_queue)
set_state_queue.cancel_join_thread()
set_state_queue.close()


class _SetStateIsDone:
Expand Down