Skip to content

Use canCollectData for LOI write permission #2448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rfontanarosa wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use canCollectData for LOI write permission #2448

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3de8246
Use canCollectData for LOI write permission
rfontanarosa Mar 9, 2026
dd5d11a
Merge branch 'master' into rfontanarosa/1887/security-write-condition…
rfontanarosa Mar 9, 2026
de398db
Merge branch 'master' into rfontanarosa/1887/security-write-condition…
rfontanarosa Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions firestore/firestore.rules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,8 @@ rules_version = '2';
allow get: if canViewLoi(getSurvey(surveyId), resource.data);
// Allow all survey users to list LOIs.
allow list: if canViewSurvey(getSurvey(surveyId));
// Allow if user is owner of the existing LOI or can manage survey.
allow update, delete: if isLoiOwner(resource.data) || canManageSurvey(getSurvey(surveyId));
// Allow if user is owner of the existing LOI and can collect data, or can manage survey.
allow update, delete: if (isLoiOwner(resource.data) && canCollectData(getSurvey(surveyId))) || canManageSurvey(getSurvey(surveyId));
}

// Apply survey-level permissions to submission documents.
Expand All @@ -194,8 +194,8 @@ rules_version = '2';
allow get: if canViewSubmission(getSurvey(surveyId), resource.data);
// Allow all survey users to list submissions.
allow list: if canViewSurvey(getSurvey(surveyId));
// Allow if user is owner of the existing submission or can manage survey.
allow update, delete: if isSubmissionOwner(resource.data) || canManageSurvey(getSurvey(surveyId));
// Allow if user is owner of the existing submission and can collect data, or can manage survey.
allow update, delete: if (isSubmissionOwner(resource.data) && canCollectData(getSurvey(surveyId))) || canManageSurvey(getSurvey(surveyId));
}

// Apply survey-level permissions to job documents.
Expand Down
Loading