Pass survey as input to sharing components

[rfontanarosa]

closes #2455

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors how survey data is provided to several UI components responsible for managing survey sharing, data visibility, and general access. By transitioning these components to receive the Survey object as an explicit input, it enhances their reusability and simplifies their internal state management, moving away from reactive service subscriptions towards a more declarative, input-driven approach using Angular's new signal primitives.

Highlights

• Component Input Refactoring: Refactored DataVisibilityControlComponent, GeneralAccessControlComponent, and ShareListComponent to receive the Survey object as an @Input() using Angular's new input() primitive, instead of subscribing to a service.
• Reactive Logic Migration: Migrated internal component logic from RxJS subscriptions to Angular's effect() primitive for reacting to changes in the Survey input, enhancing reactivity and simplifying lifecycle management.
• Simplified Lifecycle Management: Removed ngOnDestroy lifecycle hooks and Subscription management from the refactored components, as the new input() and effect() patterns handle resource cleanup automatically.
• Dialog Data Injection: Updated ShareDialogComponent to receive the Survey object directly via MAT_DIALOG_DATA injection in its constructor, eliminating the need for service subscriptions within the dialog.
• Template Updates: Modified the ShareSurveyComponent template to pass the Survey object as an input to its child sharing components (ground-share-list, ground-general-access-control, ground-data-visibility-control).

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors several sharing-related components to use Angular signal inputs for receiving the survey object, which is a good architectural improvement. The changes decouple the components from the DraftSurveyService and make them more reusable. However, a critical piece is missing: ShareSurveyComponent, the parent component, has not been updated to provide the survey object to its children or to the ShareDialogComponent. This will lead to runtime errors. My review includes a critical comment highlighting this issue.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.91%. Comparing base (79c3338) to head (f437341).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2461      +/-   ##
==========================================
- Coverage   58.92%   58.91%   -0.02%     
==========================================
  Files         111      111              
  Lines        2761     2760       -1     
  Branches      413      414       +1     
==========================================
- Hits         1627     1626       -1     
  Misses       1072     1072              
  Partials       62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.