Skip to content

Conversation

@brian-olson
Copy link
Contributor

Adding the wrapper from the grr-users group for archival sake. Thanks for sharing!

Adding the wrapper from the grr-users group for archival sake. Thanks for sharing!
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@brian-olson
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@grrrrrrrrr
Copy link
Contributor

Hey Brian,

Thanks for the PR, sorry we somehow overlooked it :(

Do you still want to get this in? Two things, first a nit, could you please trim the lines to 80 chars?
Then, the waiter doesn't do anything it could be completely removed. You probably want to call Progress once a second but you are missing that call. Let me know if you want to fix this example!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants