Skip to content
This repository was archived by the owner on Feb 15, 2022. It is now read-only.

Conversation

@satoshieguchi
Copy link

ChartRangeFilterStateRange#getEndNumber() and ChartRangeFilterStateRange#getEndTimeOfDay() should return a double value or TimeOfDay object, respectively, but nothing will be returned due to lack of "return this.end;" statements.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@satoshieguchi
Copy link
Author

I have just signed the CLA.

@googlebot
Copy link

CLAs look good, thanks!

ChartRangeFilterStateRange#getEndNumber() and ChartRangeFilterStateRange#getEndTimeOfDay() should return a double value or TimeOfDay object, respectively, but nothing will be returned due to lack of "return this.end;" statements.
@satoshieguchi satoshieguchi force-pushed the fix_ChartRangeFilterStateRange branch from 8c8e841 to 60c617a Compare April 21, 2019 08:06
@satoshieguchi
Copy link
Author

I have been working on new fixes for about two weeks.
In this process, since I messed my repository due to line endings between CR+LF and LF on my linux environment, I backed to the initial state of the repository, and made all line endings just LF, then applied my modifications to it again.
Please refer to the commit id of 60c617a to access my pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants