Update import-mailbox-to-gmail for 2026#65
Merged
eesheesh merged 31 commits intogoogle:masterfrom Feb 16, 2026
Merged
Conversation
This commit brings the script up-to-date with modern Python and Google Cloud authentication practices. Changes include: - The script is now compatible with Python 3. - All dependencies have been updated to their latest versions, including the Google API client libraries. The deprecated `oauth2client` has been replaced with `google-auth`. - A new authentication option has been added to use the `signJwt` API via Application Default Credentials, allowing the script to be run without a JSON key file in environments like Google Cloud. - A unit test has been added to verify the mbox migration logic, with mocking of the Google API. - A build script (`build.py`) has been added to run the tests and create a single-file executable using PyInstaller. The build script will now automatically install PyInstaller if it is not found. - An option to control the HTTP library's logging verbosity has been re-introduced. - The User-Agent for HTTP requests is now correctly set. - The Dockerfile has been updated to use Python 3 and reflect the script's new name. Co-authored-by: eesheesh <11871180+eesheesh@users.noreply.github.com>
…est wrapper - Configure GitHub Actions for linting, testing, and building (Docker & EXE). - Update Dockerfile to use python:3.14-rc-slim (latest). - Update README.md with Python 3 instructions. - Add run_real_import_test.py for interactive testing. - Fix linting issues in import_mailbox_to_gmail.py and add .pylintrc. - Update build-exe.mac.sh to use python3. Co-authored-by: eesheesh <11871180+eesheesh@users.noreply.github.com>
…est wrapper - Configure GitHub Actions for linting, testing, and building (Docker & EXE). - Update Dockerfile to use python:3.14-rc-slim (latest). - Update README.md with Python 3 instructions and EXE recommendation. - Add run_real_import_test.py for interactive testing with verification. - Fix linting issues in import_mailbox_to_gmail.py and add .pylintrc. - Update build-exe.mac.sh to use python3. Co-authored-by: eesheesh <11871180+eesheesh@users.noreply.github.com>
…est wrapper - Configure GitHub Actions for linting (pylint & markdownlint), testing, and building (Docker & EXE). - Update Dockerfile to use python:3-slim (latest stable). - Update README.md with Python 3 instructions, EXE recommendation, and 80-col formatting. - Add run_real_import_test.py for interactive testing with verification. - Fix linting issues in import_mailbox_to_gmail.py and add .pylintrc. - Update build-exe.mac.sh to use python3. - Add .markdownlint.json configuration. Co-authored-by: eesheesh <11871180+eesheesh@users.noreply.github.com>
…est wrapper - Configure GitHub Actions for linting (pylint & markdownlint), testing, and building (Docker & EXE). - Update Dockerfile to use python:3-slim (latest stable). - Update README.md with Python 3 instructions, EXE recommendation, and 80-col formatting. - Add run_real_import_test.py for interactive testing with verification. - Fix linting issues in import_mailbox_to_gmail.py and add .pylintrc. - Update build-exe.mac.sh to use python3. - Add .markdownlint.json configuration. Co-authored-by: eesheesh <11871180+eesheesh@users.noreply.github.com>
…est wrapper - Configure GitHub Actions for linting (pylint & markdownlint), testing, and building (Docker & EXE for Windows/macOS). - Update Dockerfile to use python:3-slim (latest stable). - Update README.md with Python 3 instructions, EXE recommendation for Windows/macOS, and 80-col formatting. - Add run_real_import_test.py for interactive testing with verification (self-contained with dummy mbox generation). - Fix linting issues in import_mailbox_to_gmail.py and add .pylintrc. - Update build-exe.mac.sh to use python3. - Add .markdownlint.json configuration. Co-authored-by: eesheesh <11871180+eesheesh@users.noreply.github.com>
…est wrapper - Configure GitHub Actions for linting (pylint & markdownlint), testing, and building (Docker & EXE for Windows/macOS). - Update Dockerfile to use python:3-slim (latest stable). - Update README.md with Python 3 instructions, EXE recommendation for Windows/macOS, and 80-col formatting. - Add run_real_import_test.py for interactive testing with verification (self-contained with dummy mbox generation). - Fix linting issues in import_mailbox_to_gmail.py and add .pylintrc. - Update build-exe.mac.sh to use python3 and handle environment variables in CI. - Add .markdownlint.json configuration and .markdownlintignore for CONTRIBUTING.md. Co-authored-by: eesheesh <11871180+eesheesh@users.noreply.github.com>
…est wrapper - Configure GitHub Actions for linting (pylint & markdownlint), testing, and building (Docker & EXE for Windows/macOS). - Update Dockerfile to use python:3-slim (latest stable). - Update README.md with Python 3 instructions, EXE recommendation for Windows/macOS, and 80-col formatting. - Add run_real_import_test.py for interactive testing with verification (self-contained with dummy mbox generation). - Fix linting issues in import_mailbox_to_gmail.py and add .pylintrc. - Update build-exe.mac.sh to use python3, handle environment variables in CI, and fix filename reference. - Add .markdownlint.json configuration and .markdownlintignore for CONTRIBUTING.md. Co-authored-by: eesheesh <11871180+eesheesh@users.noreply.github.com>
…est wrapper - Configure GitHub Actions for linting (pylint & markdownlint), testing, and building (Docker & EXE for Windows/macOS). - Update Dockerfile to use python:3-slim (latest stable). - Update README.md with Python 3 instructions, EXE recommendation for Windows/macOS, and 80-col formatting. Fixed filename references to use underscores. - Add run_real_import_test.py for interactive testing with verification (self-contained with dummy mbox generation, pagination, retries, and strict message verification). - Fix linting issues in import_mailbox_to_gmail.py and add .pylintrc. - Update build-exe.mac.sh to use python3, handle environment variables in CI, and fix filename reference. - Add .markdownlint.json configuration and .markdownlintignore for CONTRIBUTING.md. Co-authored-by: eesheesh <11871180+eesheesh@users.noreply.github.com>
Renamed the main script from `import_mailbox_to_gmail.py` to `import-mailbox-to-gmail.py` as requested. Updated all references to the script in: - `test_import.py` (updated to use dynamic import due to hyphen in filename) - `README.md` - `.github/workflows/ci.yml` - `build.py` - `build-exe.mac.sh` - `Dockerfile` - `run_real_import_test.py` Verified that tests pass and linting is clean. Co-authored-by: eesheesh <11871180+eesheesh@users.noreply.github.com>
Moved `run_real_import_test.py`, `test_import.py`, and `sample.mbox` to `tests/` directory. Updated `tests/test_import.py` and `tests/run_real_import_test.py` to correctly reference the main script and test data using relative paths. Updated `.github/workflows/ci.yml` to run pylint recursively on all python files and discover tests in `tests/`. Updated `build.py` to discover tests in `tests/` and fixed lint errors (indentation, docstrings). Fixed lint errors in `tests/test_import.py` (indentation, docstrings). Co-authored-by: eesheesh <11871180+eesheesh@users.noreply.github.com>
- Removed disabled checks from `.pylintrc`: `line-too-long`, `consider-using-f-string`, `unused-variable`, `redefined-builtin`, `ungrouped-imports`, `global-statement`, `no-member`, `invalid-name`, `too-many-locals`, `too-many-branches`, `too-many-statements`, `too-many-nested-blocks`, `broad-exception-caught`, `too-many-arguments`, `too-many-positional-arguments`.
- Refactored `import-mailbox-to-gmail.py` to fix complexity violations:
- Extracted `setup_logging`, `process_user`, `process_mbox_file`, `process_message_headers`, `import_message` helper functions.
- Updated `process_mbox_files` and `main` to use these helpers.
- Fixed code style issues:
- Long lines.
- String formatting (f-strings for regular strings, lazy formatting for logging).
- Unused variables.
- Imports grouping.
- Added localized `# pylint: disable=...` comments for violations that are structurally required or hard to refactor (e.g., `broad-exception-caught` in top-level loops, `too-many-locals` in stat aggregators).
- Updated `tests/run_real_import_test.py` to fix minor pylint issues and refactor complexity.
- Verified that `pylint --recursive=y .` now scores 10.00/10.
Co-authored-by: eesheesh <11871180+eesheesh@users.noreply.github.com>
- Removed disabled checks from `.pylintrc`: `line-too-long`, `consider-using-f-string`, `unused-variable`, `redefined-builtin`, `ungrouped-imports`, `global-statement`, `no-member`, `invalid-name`, `too-many-locals`, `too-many-branches`, `too-many-statements`, `too-many-nested-blocks`, `broad-exception-caught`, `too-many-arguments`, `too-many-positional-arguments`.
- Refactored `import-mailbox-to-gmail.py` to fix complexity violations:
- Extracted `setup_logging`, `process_user`, `process_mbox_file`, `process_message_headers`, `import_message` helper functions.
- Updated `process_mbox_files` and `main` to use these helpers.
- Renamed global `args` to `ARGS` to satisfy constant naming conventions.
- Fixed code style issues:
- Long lines.
- String formatting (f-strings for regular strings, lazy formatting for logging).
- Unused variables.
- Imports grouping.
- Added localized `# pylint: disable=...` comments for violations that are structurally required or hard to refactor.
- Updated `tests/run_real_import_test.py` to fix minor pylint issues and refactor complexity.
- Updated `tests/test_import.py` to patch `ARGS` instead of `args`, fixing a test failure.
- Verified that `pylint --recursive=y .` now scores 10.00/10.
Co-authored-by: eesheesh <11871180+eesheesh@users.noreply.github.com>
- Cleared `[MESSAGES CONTROL]` in `.pylintrc` to enable all checks.
- Added `import-mailbox-to-gmail` to `good-names` in `.pylintrc` to suppress `invalid-name` for the module.
- Refactored `import-mailbox-to-gmail.py`:
- Extracted `process_user`, `process_mbox_file`, `import_message` helpers to reduce complexity.
- Renamed global `args` to `ARGS` and `dir` to `dirname`.
- Switched to f-strings where appropriate.
- Added localized ignores for `broad-exception-caught`, `no-member`, etc.
- Updated `tests/test_import.py` to patch `ARGS` instead of `args`.
- Verified 10.00/10 pylint score.
Co-authored-by: eesheesh <11871180+eesheesh@users.noreply.github.com>
- Cleared `[MESSAGES CONTROL]` in `.pylintrc` to enable all checks. - Added `import-mailbox-to-gmail` to `good-names` in `.pylintrc`. - Refactored `import-mailbox-to-gmail.py` with helper functions to reduce complexity. - Renamed global `args` to `ARGS` and `dir` to `dirname`. - Fixed logic error where failed label creation was not incrementing `number_of_labels_failed`. - Added regression test `test_import_label_failure` in `tests/test_import.py`. - Updated tests to patch `ARGS`. - Verified 10.00/10 pylint score and passing tests. Co-authored-by: eesheesh <11871180+eesheesh@users.noreply.github.com>
- tests/test_import.py: Added unit tests for:
- Message import failures (counters increment correctly).
- User processing failures (counters increment correctly).
- Arguments: --noreplaceqp, --no-fix-msgid, --from_message.
- tests/run_real_import_test.py: Added integration test scenarios for:
- Reserved label names ("Outbox") - verified skipped.
- Invalid headers (duplicate "From") - verified failed/skipped.
- Log verification for skipped labels and failed messages.
Co-authored-by: eesheesh <11871180+eesheesh@users.noreply.github.com>
- tests/test_import.py: Added unit tests for:
- Message import failures (counters increment correctly).
- User processing failures (counters increment correctly).
- Arguments: --noreplaceqp, --no-fix-msgid, --from_message.
- tests/run_real_import_test.py: Added integration test scenarios for:
- Reserved label names ("Outbox") - verified skipped.
- Invalid headers (duplicate "From") - verified failed/skipped.
- Log verification for skipped labels and failed messages.
Co-authored-by: eesheesh <11871180+eesheesh@users.noreply.github.com>
- Removed "3.14-dev" from python-version in .github/workflows/ci.yml test matrix. - Removed `allow-prereleases: true` as it's no longer needed for "3.x". Co-authored-by: eesheesh <11871180+eesheesh@users.noreply.github.com>
- Wrapped `shutil.rmtree` in `tests/test_import.py` and `tests/run_real_import_test.py` with `try...except OSError` to prevent test failures when files are locked (common on Windows). - Logs a warning instead of raising an exception. Co-authored-by: eesheesh <11871180+eesheesh@users.noreply.github.com>
This workflow is triggered when a release is created or manually via workflow_dispatch. It builds the executable for Windows and macOS and uploads them as artifacts. Co-authored-by: eesheesh <11871180+eesheesh@users.noreply.github.com>
The macOS build and executable distribution are removed as unsigned binaries are difficult for users to run on macOS. The documentation is updated to instruct macOS users to run the Python script directly, similar to Linux users. * Removed `build-exe-macos` job from `.github/workflows/release.yml`. * Deleted `build-exe.mac.sh`. * Updated `README.md` to reflect that executables are Windows-only and updated macOS instructions to use the Python script. Co-authored-by: eesheesh <11871180+eesheesh@users.noreply.github.com>
Updated `README.md` to remove the recommendation for the macOS executable and instead instruct macOS users to run the Python script directly. This avoids issues with running unsigned binaries on macOS. The macOS build configuration remains in place but is no longer advertised in the documentation. * Updated `README.md` to state executables are for Windows only. * Updated `README.md` to include macOS in the Python script instructions. Co-authored-by: eesheesh <11871180+eesheesh@users.noreply.github.com>
- Modified `import-mailbox-to-gmail.py` to use `try...finally` with `mailbox.mbox` to ensure file handles are closed, fixing `ResourceWarning`. - Modified `tests/test_import.py` to suppress logging during tests using `logging.disable(logging.CRITICAL)` in `setUp` and restoring it in `tearDown`. This cleans up expected error logs from the test output. Co-authored-by: eesheesh <11871180+eesheesh@users.noreply.github.com>
- Updated `tests/run_real_import_test.py` to print full traceback on verification failure. - Removed invalid `pageToken` argument from `get_label_id` as `users.labels.list` does not support pagination. Co-authored-by: eesheesh <11871180+eesheesh@users.noreply.github.com>
This change adds `cache_discovery=False` to the `discovery.build` call in `import-mailbox-to-gmail.py`. This prevents the Google API client from attempting to use file-based caching, which is not needed for this application and causes a warning log about `oauth2client` version incompatibility (`INFO autodetect@__init__.py file_cache is only supported with oauth2client<4.0.0`). A new test case `test_process_user_builds_service_without_cache` is added to `tests/test_import.py` to verify this behavior. Co-authored-by: eesheesh <11871180+eesheesh@users.noreply.github.com>
This change adds `cache_discovery=False` to the `discovery.build` call in `import-mailbox-to-gmail.py`. This prevents the Google API client from attempting to use file-based caching, which is not needed for this application and causes a warning log about `oauth2client` version incompatibility (`INFO autodetect@__init__.py file_cache is only supported with oauth2client<4.0.0`). A new test case `test_process_user_builds_service_without_cache` is added to `tests/test_import.py` to verify this behavior. Code has been formatted to comply with pylint line length limits. Co-authored-by: eesheesh <11871180+eesheesh@users.noreply.github.com>
This was referenced Feb 16, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.