The generated Swift module map for j2objc_proto_library now includes export *, making all symbols from the module available in Swift.
#2636
+885
−917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s `export *`, making all symbols from the module available in Swift. This should fix up problems where people were forced to `import third_party_java_src_j2objc_jre_emul_jre_core` in swift files when using j2objc protos. PiperOrigin-RevId: 842340738
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated Swift module map for
j2objc_proto_librarynow includesexport *, making all symbols from the module available in Swift.This should fix up problems where people were forced to
import third_party_java_src_j2objc_jre_emul_jre_corein swift files when using j2objc protos.