improve iso support #315
Merged
improve iso support #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These updates not only appear to work properly for ISO encoding, they also seem required for any successful effort with negative boost values for XMP as well (ie, this resolves an important encoding bug in the current mainline). |
This was referenced Nov 6, 2024
|
While the image works fine in both Adobe and Apple software, the image fails to render in Chrome (including latest Canary). It may be ideal to make ISO support a configurable flag in the demo app. |
ram-mohan
force-pushed
the
isometadata
branch
from
c74fb1e to
f551eb7
Compare
ram-mohan
force-pushed
the
isometadata
branch
from
f551eb7 to
4bb0aa8
Compare
ram-mohan
changed the title
Test: ./ultrahdr_unit_test
communicate unsupported features to the app cleanly. Test: ./ultrahdr_unit_test
Test: ./ultrahdr_unit_test
ram-mohan
force-pushed
the
isometadata
branch
from
4bb0aa8 to
42089ad
Compare
DichenZhang1
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test: ./ultrahdr_unit_test