enable support for xmp, iso to be build time configurable #329
Conversation
|
Not that it should block the PR, but the images with both ISO and XMP gainmap metadata seem to be hitting Chromium bug 377620718. |
|
@koto While production Chrome won't render either (even Android-only, no ISO), Canary renders the ISO + XMP images just fine in my testing. As far as I can tell (in my limited testing), there is no value / need to delay this, as the issue with Chrome appears unrelated to ISO as far as I have seen. That issue seems to affect either encoding or both together, and ultimately means we need to hope the Chrome fix moves to production quickly. I have not tested Dev / Beta Chrome channels to see if they have the fix yet. |
ram-mohan
force-pushed
the
isoenable
branch
2 times, most recently
from
8871290 to
e6e5384
Compare
|
@koto Latest production Chrome 131 has resolved the gain map bug (works on 131.0.6778.109 if not slightly older, resolved in the past week). I'm seeing Brave works as well (see test #8: https://gregbenzphotography.com/hdr/#tests) |
Test: ./ultrahdr_unit_test
ram-mohan
changed the title
|
@DichenZhang1 dichen, the changes are ready for review. thank you. |
Android.bp enables xmp support by default, cmakelists.txt enables iso support by default. Based on the build system the encoded bitstream may vary. This change has no effect on decoder. The decoder by default supports both iso and xmp. If both exists iso packet is preferred. Test: ./ultrahdr_unit_test
4 participants
as per https://developer.android.com/media/platform/hdr-image-format implementations are expected to write both xmp and iso metadata by default.
Test: ./ultrahdr_app