Skip to content

Security fix: Add path validation to analyse_file tool (CWE-22) #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VadlaReddySai wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

Security fix: Add path validation to analyse_file tool (CWE-22) #251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion server/gti/gti_mcp/tools/files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,8 +259,15 @@ async def analyse_file(file_path: str, ctx: Context):
Returns:
The analysis report.
"""
import os
resolved = os.path.realpath(os.path.abspath(file_path))
allowed_dir = os.path.realpath("/tmp/gti-uploads")
if not resolved.startswith(allowed_dir + os.sep):
raise ValueError(
f"Access denied: file_path must be within {allowed_dir}"
)
async with vt_client(ctx) as client:
with open(file_path, "rb") as f:
with open(resolved, "rb") as f:
analysis = await client.scan_file_async(file=f)
logging.info(f"File {file_path} uploaded.")

Expand Down