Skip to content

Re-open stream when MMAP is disabled #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
madebymozart merged 2 commits into from
Jan 26, 2026
Merged

Re-open stream when MMAP is disabled #2338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2424aa
Re-open stream when MMAP is disabled
madebymozart Jan 26, 2026
b466f0f
Reopen stream if MMAP setting changes via global variable
madebymozart Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion samples/powerplay/src/main/cpp/PowerPlayMultiPlayer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ void PowerPlayMultiPlayer::setupAudioStream(int32_t channelCount,
bool PowerPlayMultiPlayer::openStream(oboe::PerformanceMode performanceMode) {
__android_log_print(ANDROID_LOG_INFO, TAG, "openStream()");
mLastPerformanceMode = performanceMode;
mLastMMapEnabled = isMMapEnabled();

// Use shared_ptr to prevent use of a deleted callback.
mDataCallback = std::make_shared<MyDataCallback>(this);
Expand Down Expand Up @@ -132,7 +133,9 @@ void PowerPlayMultiPlayer::triggerDown(int32_t index, oboe::PerformanceMode perf
}

// If the performance mode has changed, we need to reopen the stream.
if (performanceMode != mLastPerformanceMode) {
// Also reopen if the user has changed the MMAP policy (enabled/disabled) since the stream was opened.
if (performanceMode != mLastPerformanceMode ||
isMMapEnabled() != mLastMMapEnabled) {
teardownAudioStream();

// Attempt here to reopen the stream with the new performance mode.
Expand Down
2 changes: 2 additions & 0 deletions samples/powerplay/src/main/cpp/PowerPlayMultiPlayer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ class PowerPlayMultiPlayer : public iolib::SimpleMultiPlayer {
std::shared_ptr<MyPresentationCallback> mPresentationCallback;

oboe::PerformanceMode mLastPerformanceMode;

bool mLastMMapEnabled;
};

#endif //SAMPLES_POWERPLAYMULTIPLAYER_H