Bug/Feature: Fix audio silence when display is turned off #2340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r switched to PCM offload mode
flamme
reviewed
Jan 28, 2026
| } | ||
|
|
||
| if (!wakeLock.isHeld) { | ||
| wakeLock.acquire(10*60*1000L /*10 minutes*/) |
Collaborator
There was a problem hiding this comment.
If wake lock is held when doing audio playback, the device won't be able to go into deep suspend, which indicates the offload work may not really save much power.
flamme
reviewed
Jan 28, 2026
|
|
||
| val powerManager = getSystemService(POWER_SERVICE) as PowerManager | ||
| wakeLock = powerManager.newWakeLock(PowerManager.PARTIAL_WAKE_LOCK, "PowerPlay::AudioWakeLock") | ||
| } catch (e: Throwable) { |
Collaborator
There was a problem hiding this comment.
Could it be more specific which exception may be thrown from which function call?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses an issue where audio streams could become silent or stall when the device display is turned off.
Changes
Checklist