[Timesketch] Implement direct static file serving and tune Nginx proxy buffers#245
Draft
jaegeral wants to merge 4 commits intogoogle:mainfrom
Draft
[Timesketch] Implement direct static file serving and tune Nginx proxy buffers#245jaegeral wants to merge 4 commits intogoogle:mainfrom
jaegeral wants to merge 4 commits intogoogle:mainfrom
Conversation
Author
Do I need to bump the version here? |
Member
|
Thank you for this @jaegeral ! This looks pretty good, to update the version can you
That will fix the failing test above. There will be a final GH action that runs when thats fixed to make sure the helm chart can install properly. Did you by chance run these changes locally and were able to upload a Timesketch timeline w/o the issues you were seeing? |
Author
|
No I was not testing it locally so far, but I will test it and update the things you mentioned 👍 |
Member
|
Sweet thank you. To help you with any troubleshooting, here are some commands that might be useful:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change optimizes how Timesketch frontend assets are served to resolve Nginx warnings regarding
upstream responses being buffered to disk. By offloading static file delivery from the Python
application server (Gunicorn) to Nginx, we reduce latency and CPU overhead on the backend.
Note: This PR received lots of help by Gemini