Add NuGet.org API Key secret extractor and validator#1936
Open
Amsamms wants to merge 2 commits intogoogle:mainfrom
Open
Add NuGet.org API Key secret extractor and validator#1936Amsamms wants to merge 2 commits intogoogle:mainfrom
Amsamms wants to merge 2 commits intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Implement detection and validation of NuGet.org API keys (prefix oy2, 46 characters total) to prevent supply chain attacks via unauthorized package publishing. Closes google#1734
f3f07c7 to
35272fa
Compare
Author
|
Hi team — this NuGet.org API Key extractor has been open for 2 weeks with all CI checks green (including CLA). Would appreciate a review when you get a chance. Thanks! |
Author
|
Friendly weekly ping — this NuGet.org API Key extractor PR is now 3 weeks old with all 13 CI checks green (CLA included). Happy to address any review feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements a secret extractor and validator for NuGet.org API Keys, addressing issue #1734.
oy2, 46 characters total)oy2followed by 43 alphanumeric charactershttps://www.nuget.org/api/v2/packagewithX-NuGet-ApiKeyheader — valid keys return 400 (Bad Request, no package body), invalid keys return 401/403Files added
veles/secrets/nugetorgapikey/nugetorgapikey.goNuGetOrgAPIKey) withTokenfieldveles/secrets/nugetorgapikey/detector.gosimpletoken.Detectorveles/secrets/nugetorgapikey/detector_test.govelestest.AcceptDetectorveles/secrets/nugetorgapikey/validator.gosimplevalidate.Validatorveles/secrets/nugetorgapikey/validator_test.goRegistration
extractor/filesystem/list/list.goenricher/enricherlist/list.go.protofile changes and code regeneration)References
Test plan
🤖 Generated with Claude Code