Feature (secrets) : Added Alibaba cloud keys detector and validator#1946
Open
saurabhb-dev wants to merge 6 commits intogoogle:mainfrom
Open
Feature (secrets) : Added Alibaba cloud keys detector and validator#1946saurabhb-dev wants to merge 6 commits intogoogle:mainfrom
saurabhb-dev wants to merge 6 commits intogoogle:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces a new secret detector and validtor for Alibaba cloud keys
Fixes: #1024
Key Features
veles.pairlibrary to anchor on theLTAIprefix (Access Key ID) and perform a proximity search for the 30-character Secret Key. This minimizes false positives compared to generic string matching.Cryptographic Validation: Implemented an RPC-style signature generator. It constructs a canonicalized query string and signs it via HMAC-SHA256 (v1.0 signature) to authenticate against theSTS:GetCallerIdentityendpoint.is_ram_user: Boolean flag for account scoping.principal_name: The specific name of the user or "root".secret.protoand successfully regenerated Go types viamake protos.Verification Results
go test -v ./veles/secrets/alibabaaccesskey/...passed (100% coverage for true/false positives and signature logic).make lintreturns 0 issues, adhering to allreviveandperfsprintperformance constraints.Verified using a local
scalibrbuild. Example output fromscan-result.textproto:Checklist