Acceptance tests for secrets validator#1987
Open
alessandro-Doyensec wants to merge 9 commits intogoogle:mainfrom
Open
Acceptance tests for secrets validator#1987alessandro-Doyensec wants to merge 9 commits intogoogle:mainfrom
alessandro-Doyensec wants to merge 9 commits intogoogle:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds acceptance validator tests.
After the addition of acceptance tests these plugin failed the test:
github.com/google/osv-scalibr/veles/secrets/awsaccesskey| AnerrResp.Error.Codewas missing and the validator returnedveles.ValidationFailedinstead ofveles.ValidationInvalidgithub.com/google/osv-scalibr/veles/secrets/cloudflareapitoken| The service returnshttp.StatusBadRequeston malformed tokengithub.com/google/osv-scalibr/veles/secrets/cratesioapitoken| The service returnshttp.StatusBadRequeston malformed tokengithub.com/google/osv-scalibr/veles/secrets/grokxaiapikey| InvalidResponseCodes were not specified leading to false positives, needs further investigationgithub.com/google/osv-scalibr/veles/secrets/salesforceoauth2access| The service returns 403 for bad ouauth token, needs further investigationgithub.com/google/osv-scalibr/veles/secrets/salesforceoauth2client| The service is not testable onlinegithub.com/google/osv-scalibr/veles/secrets/salesforceoauth2refresh| The request was poorly formatted and resulted in the validator always failinggithub.com/google/osv-scalibr/veles/secrets/gcshmackey| The request creation was always failing because the host header was missing. I confirmed that the validator is now properly working.Test output