PRP: Add Argo CD and Argo Workflows container image extractors#1992
Open
Amsamms wants to merge 2 commits intogoogle:mainfrom
Open
PRP: Add Argo CD and Argo Workflows container image extractors#1992Amsamms wants to merge 2 commits intogoogle:mainfrom
Amsamms wants to merge 2 commits intogoogle:mainfrom
Conversation
Implements two new filesystem extractors for issue google#1298: - argocdimage: Extracts OCI image references from Argo CD Application and ApplicationSet YAML files, including source-level references (Helm charts, Git paths) and kustomize image overrides. - argoworkflowimage: Extracts container image references from Argo Workflow, WorkflowTemplate, CronWorkflow, and ClusterWorkflowTemplate YAML files. Handles container, script, initContainer, and sidecar image fields. Correctly handles CronWorkflow's nested spec.workflowSpec.templates structure.
Author
|
Hi @erikvarga @another-rex — gentle ping. This PR has been open for 7 days with all 13 CI checks green and no review yet. Linked PRP:Accepted issue: #1298 (Argo CD + Argo Workflows extractors). Happy to address any feedback, split, or rebase as needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1298.
This PR adds two filesystem extractors for container images defined in Argo CD and Argo Workflows manifests:
argocdimageextractorApplicationandApplicationSetresourcesspec.source.kustomize.images,spec.source.helm.valuesObject, and init/sidecar containersspec.sources)argoworkflowimageextractorWorkflowandCronWorkflowresourcesCronWorkflownested structure (spec.workflowSpec.templatesvsspec.templates)Key design decisions
.yamland.ymlfiles, usingapiVersion/kinddetection to identify relevant manifestscontainerPURL type packagesoneof configblock)containerdcontainerimage,dockercontainerimage)New()constructors per project conventionsTesting