Skip to content

refactor(config): use dedicated files for "config" and "manager" code, and rename method receiver#2551

Merged
G-Rath merged 3 commits intogoogle:mainfrom
ackama:refactor/split-config
Feb 26, 2026
Merged

refactor(config): use dedicated files for "config" and "manager" code, and rename method receiver#2551
G-Rath merged 3 commits intogoogle:mainfrom
ackama:refactor/split-config

Conversation

@G-Rath
Copy link
Copy Markdown
Collaborator

@G-Rath G-Rath commented Feb 26, 2026

While doing some deduplication for #2534, I found having these in the same file when they have the same receiver name to be confusing so I've moved them to different files and renamed the receiver for Manager to be m

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 26, 2026

Codecov Report

❌ Patch coverage is 96.92308% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.43%. Comparing base (4dfa15e) to head (6484d19).

Files with missing lines Patch % Lines
internal/config/manager.go 96.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2551      +/-   ##
==========================================
- Coverage   67.92%   67.43%   -0.49%     
==========================================
  Files         172      173       +1     
  Lines       13395    13492      +97     
==========================================
  Hits         9098     9098              
- Misses       3581     3678      +97     
  Partials      716      716              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@G-Rath G-Rath merged commit b9f296c into google:main Feb 26, 2026
18 checks passed
@G-Rath G-Rath deleted the refactor/split-config branch February 26, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants