Manually implement the Default trait for generated types #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hchataing
force-pushed
the
default-impl
branch
4 times, most recently
from
9d99b53 to
8f4e1cb
Compare
- The Default trait derivation does not support static arrays of size greater than 32. - The first enum tag is not always a value, but can also be a range of values. Thus the default value for enums must be manually determined as well. At the same time make a couple of fixes to suppress warnings when building with the java feature disabled
hchataing
force-pushed
the
default-impl
branch
from
8f4e1cb to
8e00d65
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of size greater than 32.
a range of values. Thus the default value for enums must be
manually determined as well.