Skip to content

adding alternate method to apply mask to allow XLA to detect MHA patt… #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abhinavgoel95 wants to merge 3 commits into from
Closed

adding alternate method to apply mask to allow XLA to detect MHA patt… #18

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0b6fd3
adding alternate method to apply mask to allow XLA to detect MHA patt…
abhinavgoel95 Jun 7, 2023
82ff845
Merge branch 'main' into patch/mha-mask-addition-pattern-for-xla
abhinavgoel95 Jun 26, 2023
0f21a54
Merge branch 'google:main' into patch/mha-mask-addition-pattern-for-xla
abhinavgoel95 Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion praxis/layers/attentions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1007,6 +1007,7 @@ class DotProductAttention(base_layer.BaseLayer):
decode_cache: bool = True
attention_mask_summary: bool = False
zero_fully_masked: bool = False
mha_mask_addition_pattern: bool = True
qk_einsum_tpl: LayerTpl = template_field(base_ops.EinsumOp)
pv_einsum_tpl: LayerTpl = template_field(base_ops.EinsumOp)

Expand Down Expand Up @@ -1342,8 +1343,14 @@ def _dot_atten(
logits = self._cap_logits(logits)
# Attention softmax is always carried out in fp32.
logits = logits.astype(jnp.float32)

# Apply attention masking
padded_logits = py_utils.apply_mask_to_logits(logits, atten_mask)
if self.mha_mask_addition_pattern:
padded_logits = logits + atten_mask.astype(jnp.float32)
else:
padded_logits = py_utils.apply_mask_to_logits(logits, atten_mask)


if self.attention_mask_summary:
self.add_summary('attention_mask', atten_mask)
if self.attention_extra_logit is None:
Expand Down