Create first draft of get_file_contents_kmx
#172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-westphal
approved these changes
Dec 5, 2025
panhania
force-pushed
the
feature/action-get_file_contents_kmx
branch
from
f648009 to
61f6ba9
Compare
panhania
force-pushed
the
feature/action-get_file_contents_kmx
branch
from
61f6ba9 to
854664f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to #171, this mostly sets up basic structure but does not yet cover all the functionality of the original
get_file_contents(it does not even allow to be properly invoked yet).It also has duplicated test utilities with #171—given that these are test-only, I think it is fine and once both are merged we can think how to properly deduplicate that (probably by having a wrapper for proper
libguestfsrather than shelling out toguestmount).