Add fuzzers for RRG actions #182
Conversation
| **/target/ | ||
| **/Cargo.lock |
There was a problem hiding this comment.
Let's not do that, I could easily see a Rust submodule named target (e.g. for different platforms) and then spending hours trying to debug missing files on CI.
Let's just be explicit about the files we want to ignore:
/target/
/Cargo.lock
/fuzz/target/
/fuzz/Cargo.lock
| ] | ||
|
|
||
| [workspace] | ||
| members =["."] |
| path = "utils.rs" | ||
|
|
||
| [dependencies] | ||
| libfuzzer-sys="0.4" |
|
|
||
| [lib] | ||
| name = "fuzz_utils" | ||
| path = "utils.rs" |
There was a problem hiding this comment.
Any reason for not using fuzz_utils.rs for uniformity?
| log = {version = "0.4.22", features = ["std"]} | ||
| rrg-proto = {path = "../crates/rrg-proto"} |
There was a problem hiding this comment.
Nit: inconsistent brace spacing (line above is style the rest of the project follows).
|
|
||
| let full_path = root_path.join(&safe_path); | ||
|
|
||
| // Ensure Parent Directories Exist |
| return None; | ||
| } | ||
|
|
||
| let mut file = unsafe { File::from_raw_fd(fd) }; |
There was a problem hiding this comment.
https://doc.rust-lang.org/book/ch20-01-unsafe-rust.html
Whenever we write an unsafe function, it is idiomatic to write a comment
starting with SAFETY and explaining what the caller needs to do to call
the function safely. Likewise, whenever we perform an unsafe operation, it
is idiomatic to write a comment starting with SAFETY to explain how the
safety rules are upheld.
| if file.write_all(content).is_err() { | ||
| return None; | ||
| } | ||
|
|
||
| std::mem::forget(file); |
There was a problem hiding this comment.
Maybe instead of wrapping, calling write_all and forget we can just do libc::write instead?
|
|
||
| impl Drop for MemFd { | ||
| fn drop(&mut self) { | ||
| unsafe { libc::close(self.fd) }; |
There was a problem hiding this comment.
Similar comment about SAFETY comment.
There was a problem hiding this comment.
Hmm, I'm not sure how this file is used here. CTRL + F for disk_images_corpus yields no results.
2 participants
No description provided.