Placeshifter for windows fixes [ci release]#502
Merged
Narflex merged 3 commits intogoogle:masterfrom May 23, 2025
Merged
Conversation
Collaborator
|
Looks good, once the workflow completes with success I'll merge it (need to step out for a bit, so it will definitely be done before I get back). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were 2 more methods that needed casting (.mark and .rewind)
I also corrected an issue in my windows build that resolved the consolewin issue so the placeshifter launcher now matches the client to use the registry to optionally launch and log to a console window. I therefore removed the file logging I had added in the .12 release.