Fix spelling issues by codewithbear · Pull Request #106 · google/sbsim

codewithbear · 2025-07-09T09:16:46Z

This PR contains the following modifications:

AI (anthropic/claude-sonnet-4-20250514):

Fix spelling mistakes in documentation and python comments. 
** Do not correct the style **
** Do not fix spelling in variable names **
** Do not modify python code **
** Do not fix upper-lower case issues **
** Do not fix redundant/incorrect dash (-) issues **
** Do not fix correct regional variations such as British English.**
Example NOT TO FIX because those are correct: 
authorization, visualizing, behavior, normalize, carbon-emission, _to_kwh

(Slicing enabled: Yes)

Generated by Morph

google-cla · 2025-07-09T09:16:52Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

codewithbear · 2025-07-09T09:56:29Z

smart_control/simulator/constants.py

-# Here we wish to specifically set exterior space as indistinguishable
-# from exterior walls, as we wish to perform connectedComponents only on
-# connected groups of interior space. Thus, we set exterior space to a generic
-# space value, i.e. 0.
-GENERIC_SPACE_VALUE_IN_CONNECTION_INPUT = 0
-


removed a duplicated block

MJR TODO: verify duplicate block exists

codewithbear · 2025-07-09T09:58:42Z

@s2t2 I have reapplied my change and manually went through the changes to discard irrelevant/incorrect ones.

s2t2

@codewithbear thanks for the update! I just did a first pass review and made some comments for myself to double check. I may pull down your branch and make some updates if that's alright.

s2t2 · 2025-07-10T12:46:10Z

smart_control/utils/conversion_utils.py


  Args:
-    fahrenheit: Temperature in Kelvin, where 273K = 32°F.
+    fahrenheit: Temperature in Fahrenheit, where 32°F = 273K.


we would want to revert this change in units

s2t2 · 2025-07-10T12:49:21Z

smart_control/environment/environment.py


      if not single_observation_response.observation_valid:
-        logging.warn(
+        logging.warning(


OK. https://stackoverflow.com/questions/15539937/whats-the-difference-between-logging-warn-and-logging-warning-in-python

smart_control/reinforcement_learning/scripts/train.py

s2t2 · 2025-07-10T12:55:34Z

smart_control/simulator/simulator.py


    If the maximum difference in the grid is less than some small constant,
-    conversion_threshold, then quit. Otherwise, return to step 2.
+    convergence_threshold, then quit. Otherwise, return to step 2.


MJR TODO: double check this

s2t2 · 2025-07-10T12:56:27Z

smart_control/simulator/smart_device.py


    Raises:
-      AttributeError: If requested field was not declared action or does
+      AttributeError: If requested field was not declared as action or does


MJR TODO: check this

s2t2 · 2025-07-10T12:58:51Z

smart_control/utils/conversion_utils.py

    A ValueError if the input value <= absolute 0, −459.67°F.
  """
-  if fahrenheit <= -495.67:
+  if fahrenheit <= -459.67:


MJR TODO: determine whether the docstring needs to change or the code needs to change

s2t2 · 2025-07-10T13:00:08Z

smart_control/utils/energy_utils.py


  Raises:
-    ValueError if neither design_hp or break_hp are provided.
+    ValueError if neither design_hp or brake_hp are provided.


MJR TODO: double check

s2t2 · 2025-07-10T13:00:50Z

smart_control/utils/reader_lib.py


 class BaseReader(metaclass=abc.ABCMeta):
-  """Abstract base class for writing the building and reward protos."""
+  """Abstract base class for reading the building and reward protos."""


MJR TODO: verify

s2t2 · 2025-07-10T13:01:34Z

smart_control/simulator/constants.py

-# Here we wish to specifically set exterior space as indistinguishable
-# from exterior walls, as we wish to perform connectedComponents only on
-# connected groups of interior space. Thus, we set exterior space to a generic
-# space value, i.e. 0.
-GENERIC_SPACE_VALUE_IN_CONNECTION_INPUT = 0
-


MJR TODO: verify duplicate block exists

s2t2 · 2025-07-10T13:04:23Z

smart_control/utils/energy_utils_test.py

  ):
    p1 = energy_utils.get_water_pump_power(
        pump_duty_cycle=pump_duty_cycle,
-        pump_speed_percentage=pump_speed_percantage,


MJR TODO: verify we have changed all instances of pump_speed_percantage

codewithbear · 2025-07-10T13:18:24Z

@s2t2 thanks for reviewing! Sorry for a wide-spread change. I'm evaluating whether LLMs make good use case for spell checking (apparently they get too eager sometimes) and trying to make a useful contribution along the way. I verified and corrected the changes manually to my best judgement. Let me know if I can help addressing issues or tidying the pull request further.

s2t2 · 2025-07-10T17:59:58Z

@codewithbear all good! It is fun to see what the agents are capable of and how they operate. If you would like to fix those "line too long" errors, that would be helpful - just let me know. Otherwise no worries and I can get to them.

codewithbear · 2025-07-11T08:43:50Z

@s2t2 I fixed the long lines

s2t2 · 2025-07-14T18:55:48Z

Nice, thank you! 🙌

codewithbear force-pushed the fix-issue-53-spellcheck branch 2 times, most recently from 5bb9880 to dedc15c Compare July 9, 2025 09:55

codewithbear commented Jul 9, 2025

View reviewed changes

s2t2 reviewed Jul 10, 2025

View reviewed changes

This comment was marked as resolved.

Sign in to view

codewithbear added 2 commits July 11, 2025 09:42

Fix spelling issues

dd87038

fix long lines

aa881a1

codewithbear force-pushed the fix-issue-53-spellcheck branch from b3703d7 to aa881a1 Compare July 11, 2025 08:43

Conversation

codewithbear commented Jul 9, 2025

Uh oh!

google-cla bot commented Jul 9, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codewithbear commented Jul 9, 2025

Uh oh!

s2t2 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

codewithbear commented Jul 10, 2025

Uh oh!

s2t2 commented Jul 10, 2025

Uh oh!

codewithbear commented Jul 11, 2025

Uh oh!

s2t2 commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

s2t2 commented Jul 14, 2025 •

edited

Loading