Skip to content

[LBNL] Exterior radiative heat transfer implementation #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ecosang wants to merge 13 commits into
base: copybara_push
Choose a base branch
from
Draft

[LBNL] Exterior radiative heat transfer implementation #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0912175
add pvlib in poetry
ecosang Oct 21, 2025
e568ea1
add sky temperature solar radiation
ecosang Oct 23, 2025
7b3e7a9
Merge branch 'google:copybara_push' into update_weather_format
ecosang Oct 29, 2025
9df8b9e
Merge branch 'google:copybara_push' into update_weather_format
ecosang Dec 30, 2025
0054299
Merge branch 'google:copybara_push' into update_weather_format
ecosang Jan 22, 2026
0f56d52
add solar radiation for weather_controller
ecosang Jan 24, 2026
7bb653f
initial implementation of exterior radiation based on iterative approach
ecosang Jan 27, 2026
7042f80
add exteiror radiation for iterative approach including transmittance
ecosang Jan 30, 2026
363c5e8
update tf_version
ecosang Feb 5, 2026
fc58068
add ext_radiation
ecosang Feb 6, 2026
ef2ee23
Merge branch 'google:copybara_push' into ext_radiation
ecosang Feb 6, 2026
f60e456
merge weather_controller update from copybara_push
ecosang Feb 23, 2026
aa7cf9c
add ignored weather file
ecosang Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ typing-extensions = "^4.12.2"
ipython = "^8.27.0"
importlib-resources = { version = "*", python = "<3.11" }
python-dotenv = "^1.1.0"
pvlib = "^0.13.1"

[tool.poetry.group.dev.dependencies]
pytest = "^8.3.5"
Expand Down
25 changes: 25 additions & 0 deletions smart_control/configs/resources/sb1/weather_data/local_weather_test_data.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
,Time,StationName,Location,TempC,DewPointC,BarometerMbar,Rain,RainTotal,WindspeedKmph,WindDirection,SkyCoverage,VisibilityKm,Humidity,TempF
0,20230701-0000,Mountain View Moffett Field Naval Air Station,"Mountain View, California, US",20.0,15.0,-9999.0,-9999.0,-9999.0,9.360000000000001,350,0,-9999.0,75.0,68.0
1,20230701-0100,Mountain View Moffett Field Naval Air Station,"Mountain View, California, US",21.0,15.0,-9999.0,-9999.0,-9999.0,12.959999999999999,350,0,-9999.0,70.0,69.8
2,20230701-0200,Mountain View Moffett Field Naval Air Station,"Mountain View, California, US",22.0,15.0,-9999.0,-9999.0,-9999.0,14.76,350,0,-9999.0,65.0,71.6
3,20230701-0300,Mountain View Moffett Field Naval Air Station,"Mountain View, California, US",25.0,15.0,-9999.0,-9999.0,-9999.0,12.959999999999999,340,0,-9999.0,50.0,77.0
4,20230701-0400,Mountain View Moffett Field Naval Air Station,"Mountain View, California, US",25.0,15.0,-9999.0,-9999.0,-9999.0,16.56,350,0,-9999.0,50.0,77.0
5,20230701-0500,Mountain View Moffett Field Naval Air Station,"Mountain View, California, US",25.0,15.0,-9999.0,-9999.0,-9999.0,18.36,350,0,-9999.0,50.0,77.0
6,20230701-0600,Mountain View Moffett Field Naval Air Station,"Mountain View, California, US",26.0,14.0,-9999.0,-9999.0,-9999.0,12.959999999999999,330,0,-9999.0,40.0,78.8
7,20230701-0700,Mountain View Moffett Field Naval Air Station,"Mountain View, California, US",24.0,14.0,-9999.0,-9999.0,-9999.0,16.56,340,0,-9999.0,50.0,75.2
8,20230701-0800,Mountain View Moffett Field Naval Air Station,"Mountain View, California, US",23.0,13.0,-9999.0,-9999.0,-9999.0,16.56,330,0,-9999.0,50.0,73.4
9,20230701-0900,Mountain View Moffett Field Naval Air Station,"Mountain View, California, US",22.0,14.0,-9999.0,-9999.0,-9999.0,14.76,330,0,-9999.0,60.0,71.6
10,20230701-1000,Mountain View Moffett Field Naval Air Station,"Mountain View, California, US",21.0,14.0,-9999.0,-9999.0,-9999.0,7.5600000000000005,300,25,-9999.0,65.0,69.8
11,20230701-1100,Mountain View Moffett Field Naval Air Station,"Mountain View, California, US",22.0,15.0,-9999.0,-9999.0,-9999.0,9.360000000000001,350,50,-9999.0,60.0,71.6
12,20230701-1200,Mountain View Moffett Field Naval Air Station,"Mountain View, California, US",23.0,15.0,-9999.0,-9999.0,-9999.0,12.959999999999999,350,100,-9999.0,50.0,73.4
13,20230701-1300,Mountain View Moffett Field Naval Air Station,"Mountain View, California, US",24.0,15.0,-9999.0,-9999.0,-9999.0,14.76,350,0,-9999.0,65.0,75.2
14,20230701-1400,Mountain View Moffett Field Naval Air Station,"Mountain View, California, US",24.0,15.0,-9999.0,-9999.0,-9999.0,12.959999999999999,340,0,-9999.0,50.0,75.2
15,20230701-1500,Mountain View Moffett Field Naval Air Station,"Mountain View, California, US",25.0,15.0,-9999.0,-9999.0,-9999.0,16.56,350,0,-9999.0,50.0,77
16,20230701-1600,Mountain View Moffett Field Naval Air Station,"Mountain View, California, US",24.5,15.0,-9999.0,-9999.0,-9999.0,18.36,350,0,-9999.0,50.0,76.1
17,20230701-1700,Mountain View Moffett Field Naval Air Station,"Mountain View, California, US",24.0,14.0,-9999.0,-9999.0,-9999.0,12.959999999999999,330,0,-9999.0,40.0,75.2
18,20230701-1800,Mountain View Moffett Field Naval Air Station,"Mountain View, California, US",23.0,14.0,-9999.0,-9999.0,-9999.0,16.56,340,0,-9999.0,50.0,73.4
19,20230701-1900,Mountain View Moffett Field Naval Air Station,"Mountain View, California, US",22.0,13.0,-9999.0,-9999.0,-9999.0,16.56,330,0,-9999.0,50.0,71.6
20,20230701-2000,Mountain View Moffett Field Naval Air Station,"Mountain View, California, US",21.0,14.0,-9999.0,-9999.0,-9999.0,14.76,330,0,-9999.0,50.0,69.8
21,20230701-2100,Mountain View Moffett Field Naval Air Station,"Mountain View, California, US",19.0,14.0,-9999.0,-9999.0,-9999.0,7.5600000000000005,300,0,-9999.0,40.0,66.2
22,20230701-2200,Mountain View Moffett Field Naval Air Station,"Mountain View, California, US",18.0,13.0,-9999.0,-9999.0,-9999.0,14.76,330,0,-9999.0,50.0,64.4
23,20230701-2300,Mountain View Moffett Field Naval Air Station,"Mountain View, California, US",16.5,13.0,-9999.0,-9999.0,-9999.0,7.5600000000000005,300,0,-9999.0,50.0,61.7
26 changes: 26 additions & 0 deletions smart_control/simulator/benchmark_results_23x12.txt
View file
Open in desktop
Copy link
Collaborator

@s2t2 s2t2 Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because these files aren't necessarily code, let's consider moving them to the "docs" directory:

  • smart_control/simulator/benchmark_results_23x12.txt
  • smart_control/simulator/temperature_comparison_lwx_lwr.png

Perhaps we can add them to a new "docs/experiments/YOUR_EXPERIMENT_NAME_HERE" directory.

In that directory, you can feel free to create a new docs page (like "index.md") to display these results (and eventually link to the paper).

Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
============================================================
BENCHMARK RESULTS: Iterative vs Tensorized Simulator
============================================================

Configuration:
Grid size: 23 x 12 (276 CVs)
Number of steps: 10
Time step: 300.0 seconds
Convergence: 0.001
Iteration limit: 500

------------------------------------------------------------
Iterative (SimulatorFlexibleGeometries):
Total time: 10.1357 seconds
Average time: 1.0136 seconds/step
Per-step times: ['1.4483', '0.9421', '0.9256', '0.9588', '0.9623', '0.9541', '0.9875', '0.9556', '0.9989', '1.0025']

------------------------------------------------------------
Tensorized (TFSimulator):
Total time: 2.7237 seconds
Average time: 0.2724 seconds/step
Per-step times: ['0.4794', '0.1416', '0.1738', '0.2651', '0.2625', '0.2811', '0.2357', '0.3039', '0.1335', '0.4471']

------------------------------------------------------------
SPEEDUP: 3.72x faster with TFSimulator
============================================================
Loading