Conversation
This enables other backends (JAX, Pytorch, TensorFlow).
Summary of ChangesHello @wsxrdv, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the GPAM model implementation to exclusively use the Keras3 API, moving away from TensorFlow-specific components. This fundamental change is crucial for allowing the model to run seamlessly across various Keras3 backends, including JAX, PyTorch, and TensorFlow, thereby enhancing its flexibility and portability without altering its core functionality. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Do not submit until all GPAM config experiments have been verified. |
There was a problem hiding this comment.
Code Review
This pull request effectively migrates the GPAM model from using TensorFlow-specific APIs to pure Keras 3, which is a great step towards enabling multi-backend support. The changes are thorough and correctly replace TensorFlow functions with their Keras counterparts. I've made one suggestion to improve the readability of a tensor splitting operation by using slicing instead of keras.ops.split, which has different semantics from the original tf.split. Overall, this is a solid contribution.
| u, v, base = keras.ops.split( | ||
| uv, | ||
| [self.expand_dim, self.expand_dim + self.expand_dim], | ||
| axis=-1, | ||
| ) |
There was a problem hiding this comment.
While using keras.ops.split is functionally correct, it's less readable than the original tf.split because it uses split indices rather than chunk sizes. For better clarity and maintainability, consider using tensor slicing, which is more explicit about the intended chunk sizes and avoids potential confusion with the different split function semantics between TensorFlow and Keras/NumPy.
u = uv[..., :self.expand_dim]
v = uv[..., self.expand_dim:self.expand_dim + self.expand_dim]
base = uv[..., self.expand_dim + self.expand_dim:]
This enables other backends (JAX, Pytorch, TensorFlow). See https://keras.io/getting_started/#configuring-your-backend
Either set
KERAS_BACKEND="jax"or change your configuration in
~/.keras/keras.json.