Skip to content

DOM text reinterpreted as HTML Update inject.js#262

Open
Shivam7-1 wants to merge 1 commit intogoogle:masterfrom
Shivam7-1:patch-2
Open

DOM text reinterpreted as HTML Update inject.js#262
Shivam7-1 wants to merge 1 commit intogoogle:masterfrom
Shivam7-1:patch-2

Conversation

@Shivam7-1
Copy link
Copy Markdown

By using innerText, it will avoid the risk of HTML injection, as these properties automatically escape any HTML special characters in the provided text. This helps prevent cross-site scripting (XSS) vulnerabilities by treating the input as plain text rather than interpreted HTML. Always be cautious when dealing with user input or dynamic content to prevent security risks.

@Shivam7-1
Copy link
Copy Markdown
Author

Hi @sirdarckcat Could You Please Review this PR
Thanks

@Shivam7-1
Copy link
Copy Markdown
Author

Hi @sirdarckcat Could You Please Review this PR
Thanks

@NeilFraser
Copy link
Copy Markdown

In this case innerHTML is being used as a getter, not a setter, so the existing code is perfectly safe. Further, it appears that changing this to text-only would break the following match, which seems to be looking for HTML attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants