Fix & refactor dev docker-entrypoint.sh script#3721
Fix & refactor dev docker-entrypoint.sh script#3721jkppr wants to merge 5 commits intogoogle:masterfrom
Conversation
… per dev env preventing frequent re-authentication after each restart. * Adding the local key to the gitignore file to prevent leakages in PRs * Fix some format missmatches with sed commands on timesketch.conf * Moving configs that don't need change to links instead of copies
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several valuable improvements to the development Docker environment. The change to a persistent secret key is a great enhancement for developer experience, and adding the key file to .gitignore is a necessary security measure. The refactoring of configuration file handling from copies to symbolic links is a good move for a dev setup, and the fixes to the various sed commands correct existing bugs. My review includes a critical suggestion to improve the safety of sed commands that use environment variables to prevent script failures and potential injection vulnerabilities. I've also included a suggestion to refactor the creation of symbolic links for better maintainability.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2 participants
closes #3709