drop dependencies on matcher and quiver, drop matcher library #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| extension on Map<String, String?> { | ||
| bool equals(Map<String, String?> other) { |
Member
There was a problem hiding this comment.
can we just use collectionEquals from dart:collection?
Collaborator
Author
There was a problem hiding this comment.
We would have to add a dependency on package:collection to get that afaik, and we only need shallow equality which is trivial to implement here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change due to dropping the matcher libraries, but this package really never should have had that dependency and its a blocker for use in many cases.